Create tests for APG design pattern example: Tri-State Checkbox #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following CSS and JS references have been removed: * `../../css/core.css` * `../../js/examples.js` * `../../js/highlight.pack.js` * `../../js/app.js` The following references have been modified to match the directory structure of code once added to the aria-at repo: * `../css/checkbox.css` -> `css/checkbox.css` The reference to https://www.w3.org/StyleSheets/TR/2016/base.css has been maintained.
…dex Attributes' and source code sections
… setup scripts The links are implemented with an `href` attribute which references their own ID. This pattern creates links which are valid (according to the W3C's validator) but don't move the keyboard focus if accidentally activated by a tester.
IsaDC
approved these changes
Nov 12, 2020
…ating to the checkbox
…A tests when navigating to checkbox and checkbox group
|
Review notes:
Both of the above can easily be fixed by merging master into this tests branch, adding the timestamped directory and then allowing the test pages to be regenerated. But there are currently merge conflicts in files that haven't been manually touched during creation of this PR, such as the unrelated menubar editor tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
Resolves #322.